feat(s2n-quic-events): Adds events for s2n-quic-dc #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Sep 17, 2024
camshaft
approved these changes
Sep 19, 2024
Comment on lines
+174
to
+175
| #[doc = r" &mut self,"] | ||
| #[doc = r" context: &mut Self::ConnectionContext,"] |
There was a problem hiding this comment.
Hmm looks like we'll need to modify this example as well. But we can have that as a follow-up.
There was a problem hiding this comment.
Eh yeah, wasn't sure what we wanted to do with the docs. That will be a follow up.
| #[doc = r""] | ||
| #[doc = r" ```no_run"] | ||
| #[doc = r" # mod s2n_quic { pub mod provider { pub mod event {"] | ||
| #[doc = r" # pub use s2n_quic_core::event::{api as events, api::ConnectionInfo, api::ConnectionMeta, Subscriber};"] |
There was a problem hiding this comment.
Same here. We need to reference the correct crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
This PR includes changes to generate events for both s2n-quic and s2n-quic-dc. The biggest difference is that s2n-quic-dc will be passing around a single, shared Subscriber, which means that we need to produce events that take an immutable reference to the Subscriber, rather than a mutable reference. This has some cascading effects that you can see in this PR.
Call-outs:
I basically tokenized everything, not sure if this is how we want this to look. My goal was to make sure the original generated.rs didn't change at all with this change.
Testing:
Compiles. I included an example event in the dc folder to show what is produced from the change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.